[interop] Implement Diagnostics and Handling Errors #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikeokoronkwo
changed the title
srujzs
reviewed
Jul 22, 2025
nikeokoronkwo
added a commit
to nikeokoronkwo/web
that referenced
this pull request
Jul 30, 2025
commit da1dd5d Author: Devon Carew <[email protected]> Date: Thu Jul 24 10:24:40 2025 -0700 switch CI to using workflow files (dart-lang#428) * switch CI to using workflow files * update the sdk matrix * review feedback * remove format sdk version check commit 8ffaf5e Author: Nikechukwu <[email protected]> Date: Wed Jul 23 12:17:55 2025 -0400 [interop] Implement Diagnostics and Handling Errors (dart-lang#426) * implemented diagnostics * added extra invalid semantic
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 30, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/40607dc..7fbe88a): 7fbe88a 2025-07-25 Jacob MacDonald refine the prompt and fix the extension listener (dart-lang/ai#244) 8d2384b 2025-07-25 Jacob MacDonald add some intellij files to gitignore (dart-lang/ai#245) e09e469 2025-07-24 Jacob MacDonald add prompt for using flutter driver to write a test for a user journey (dart-lang/ai#243) 88d7a4d 2025-07-23 Jacob MacDonald Flutter driver updates, add screenshot support back (dart-lang/ai#241) http (https://github.com/dart-lang/http/compare/4a90d16..afda310): afda310 2025-07-23 Brian Quinlan [cronet] Support aborting requests (dart-lang/http#1797) test (https://github.com/dart-lang/test/compare/c201cc9..6aeb1e4): 6aeb1e4f 2025-07-24 Nate Bosch Consider NaN a match for itself (dart-lang/test#2524) 65a37698 2025-07-23 Nate Bosch Use latest analyzer and language version (dart-lang/test#2523) web (https://github.com/dart-lang/web/compare/767151e..da1dd5d): da1dd5d 2025-07-24 Devon Carew switch CI to using workflow files (dart-lang/web#428) 8ffaf5e 2025-07-23 Nikechukwu [interop] Implement Diagnostics and Handling Errors (dart-lang/web#426) Change-Id: I499491c4c1466cb1c81cf5e4bbff4a484e880e57 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442560 Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
nikeokoronkwo
added a commit
that referenced
this pull request
Aug 6, 2025
* added support for glob entries * added support for properly working with dir globs * changed ext to .idl * minor fmt * minor fixes * Squashed commit of the following: commit da1dd5d Author: Devon Carew <[email protected]> Date: Thu Jul 24 10:24:40 2025 -0700 switch CI to using workflow files (#428) * switch CI to using workflow files * update the sdk matrix * review feedback * remove format sdk version check commit 8ffaf5e Author: Nikechukwu <[email protected]> Date: Wed Jul 23 12:17:55 2025 -0400 [interop] Implement Diagnostics and Handling Errors (#426) * implemented diagnostics * added extra invalid semantic * added node version for web generator * minor config fix * updated node version to fix GHA bug * changed `globSync` API to use string path rather than `fs.Dirent` * formatting * removed config test * resolved commits * fixed bug preventing files from being returned * formatting and analyzing fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #421
This PR adds support for handling diagnostics and errors when parsing TS declaration files for the generator to transform, preventing the generator from handling invalid TS files.
Diagnostics are printed in the following format
And the process exits with status code 1.